[FLINK-36640] Add autoscalerResetNonce to jobSpec #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1996fanrui
reviewed
Jan 9, 2025
.../apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java
Outdated
Show resolved
Hide resolved
1996fanrui
approved these changes
Jan 10, 2025
Member
1996fanrui
left a comment
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks @gyfora for the clarification, I only left one minor comment, please take a look in your free time, thanks~
.../apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The main purpose is to allow users to easily and explicitly clear all autoscaler state and parallelism overrides.
Currently users need to toggle the autoscaler on/off to clear the parallelism settings which relies on implicit internal behaviour and is not always easy to execute safely. Unfortunately the on-off workaround requires 2 spec changes which need to be submitted carefully one after the other as the operator may only look at the 2nd one and then nothing happens.
Brief change log
Verifying this change
New unit tests have been added to cover the reset logic
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: yesDocumentation